[chore][checkapi] Do not enforce that all packages must have exactly one function #28886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exposed, exit with no error
songy23
approved these changes
Nov 6, 2023
|
After this PR merged, maybe we can assign the function |
|
@dmitryax you reported this more or less, I saw you having a bad time with encoding extensions because of it. Please review when you have time. |
dmitryax
approved these changes
Nov 17, 2023
graphaelli
pushed a commit
to graphaelli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…one function (open-telemetry#28886) If no functions are exposed, exit with no error. This change allows to remove `extension/encoding` from the allowlist.
aishyandapalli
pushed a commit
to aishyandapalli/opentelemetry-collector-contrib
that referenced
this pull request
Nov 17, 2023
…one function (open-telemetry#28886) If no functions are exposed, exit with no error. This change allows to remove `extension/encoding` from the allowlist.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…one function (open-telemetry#28886) If no functions are exposed, exit with no error. This change allows to remove `extension/encoding` from the allowlist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no functions are exposed, exit with no error.
This change allows to remove
extension/encodingfrom the allowlist.